Fix ov::Any string conversion for windows#35714
Open
rasapala wants to merge 1 commit intoopenvinotoolkit:masterfrom
Open
Fix ov::Any string conversion for windows#35714rasapala wants to merge 1 commit intoopenvinotoolkit:masterfrom
rasapala wants to merge 1 commit intoopenvinotoolkit:masterfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Fix unsafe type conversion in CPU plugin property handling
Fixes a potential crash caused by forcing numeric ov::Any values to
std::string through iostream conversion, which is unstable on Windows.
The CPU plugin's Config::readProperties unconditionally converts incoming
plugin properties to std::string before parsing, triggering unsafe iostream
type conversions when clients pass numeric types (int64_t, int) for
NUM_STREAMS or similar numeric properties.
This causes:
Fix: Check the actual ov::Any type before conversion. Use native casts
for numeric types (int64_t, int) and only use iostream conversion path
for true string values.
Safe path is: numeric input -> std::to_string -> string -> parse
Unsafe path was: numeric input -> iostream conversion -> corrupted string -> crash
Fixes clients that pass:
Changes:
Tickets:
AI Assistance: