Skip to content

Commit

Permalink
dpdk: Fix dpdk logs being split over multiple lines.
Browse files Browse the repository at this point in the history
More recent versions of the vprintf() implementation in glibc are
exhibiting this truncation behavior due to an internal buffer size
change. According to the glibc developers, this is not considered
a bug (see: https://sourceware.org/bugzilla/show_bug.cgi?id=31137).

To prevent buffer truncation, remove the request for unbuffered
output.

Acked-by: Kevin Traynor <[email protected]>
Acked-by: Mike Pattrick <[email protected]>
Signed-off-by: Eelco Chaudron <[email protected]>
  • Loading branch information
chaudron committed Nov 11, 2024
1 parent c6fc230 commit 5c13ad0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/dpdk.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ dpdk_init__(const struct smap *ovs_other_config)
if (log_stream == NULL) {
VLOG_ERR("Can't redirect DPDK log: %s.", ovs_strerror(errno));
} else {
setbuf(log_stream, NULL);
rte_openlog_stream(log_stream);
}

Expand Down

0 comments on commit 5c13ad0

Please sign in to comment.