Speed up achievement scoring.#2712
Merged
Alex-Jordan merged 1 commit intoMay 20, 2025
Merged
Conversation
drgrice1
force-pushed
the
achievement-scoring-speed-up
branch
2 times, most recently
from
7e6dbde to
94d4d67
Compare
drgrice1
force-pushed
the
achievement-scoring-speed-up
branch
from
94d4d67 to
25100a9
Compare
Member
Author
|
For testing here is the class list: https://github.com/user-attachments/files/19825750/longDemoCourse.lst.txt |
Member
Author
|
For testing here is that class list: https://github.com/user-attachments/files/19825750/longDemoCourse.lst.txt |
drgrice1
force-pushed
the
achievement-scoring-speed-up
branch
2 times, most recently
from
a2093f0 to
6fdbc70
Compare
Contributor
|
Before this, scoring just one achievement for all 5000 users took 15 seconds. Now it's instant. |
First get all of the necessary achievement data from the database, then process it and print it to the file. Comparing scoring all course achievements for all users in a course with 5000 users shows a considerable speed improvement. It takes more than three minutes for this with the develop branch, and less than 3 seconds with this pull request. Obviously the generated scoring files are identical.
drgrice1
force-pushed
the
achievement-scoring-speed-up
branch
from
6fdbc70 to
d30a5d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First get all of the necessary achievement data from the database, then process it and print it to the file.
Comparing scoring all course achievements for all users in a course with 5000 users shows a considerable speed improvement. It takes more than three minutes for this with the develop branch, and less than 3 seconds with this pull request.
Obviously the generated scoring files are identical.