[feature] New ws endpoint for all all Location broadcast #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented API to return indoor coordinates of devices for a given location. Closes #828 --------- Co-authored-by: Gagan Deep <[email protected]>
Implemented a new websocket endpoint 'location/all/' with updated user permission from base clases from django-loci. Fixes #1157
pandafy
reviewed
Dec 4, 2025
| netjsonconfig @ https://github.com/openwisp/netjsonconfig/archive/refs/heads/1.3.tar.gz | ||
| django-x509 @ https://github.com/openwisp/django-x509/archive/refs/heads/1.4.tar.gz | ||
| django-loci @ https://github.com/openwisp/django-loci/archive/refs/heads/1.3.tar.gz | ||
| django-loci @ https://github.com/openwisp/django-loci/tarball/feature/191-new-ws-endpoint-for-all-location |
Comment on lines
+27
to
+33
| if ( | ||
| result | ||
| and not user.is_superuser | ||
| and not user.is_manager(location.organization) | ||
| ): | ||
| return False | ||
| return result |
Member
There was a problem hiding this comment.
Suggested change
| if ( | |
| result | |
| and not user.is_superuser | |
| and not user.is_manager(location.organization) | |
| ): | |
| return False | |
| return result | |
| return result and (user.is_superuser or user.is_manager(location.organization)) |
pandafy
reviewed
Dec 5, 2025
Comment on lines
+44
to
+48
| path( | ||
| "api/v1/controller/location/<uuid:pk>/indoor-coordinates/", | ||
| geo_views.indoor_coordinates_list, | ||
| name="indoor_coordinates_list", | ||
| ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #1157.
Description of Changes
location/allfrom base django-loci clases with updated user permissions.Screen Recording
Screencast.from.2025-11-13.02-20-06.webm