[mpmd] Fix attribute preservation and add tests for inline merge in UniquifyFunctionInputsOutputsPass.#1369
Open
copybara-service[bot] wants to merge 1 commit into
Open
[mpmd] Fix attribute preservation and add tests for inline merge in UniquifyFunctionInputsOutputsPass.#1369copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_923406495
branch
from
294348e to
1ef22ca
Compare
…niquifyFunctionInputsOutputsPass. - Preserve inferred_by and call_counter attributes from the merge target through MergeRegionOps (which erases both operands). Previously, SetInferredByAttr was called on the erased merge_target, causing a use-after-free. Now we save attrs before the merge and restore after. - Replace unreachable `return false` in remove_if with SDY_CHECK assertion. - Add tests for block-argument-only fragments and producer-merge case. PiperOrigin-RevId: 923406495
copybara-service
Bot
force-pushed
the
test_923406495
branch
from
1ef22ca to
c6a37f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[mpmd] Fix attribute preservation and add tests for inline merge in UniquifyFunctionInputsOutputsPass.
through MergeRegionOps (which erases both operands). Previously,
SetInferredByAttr was called on the erased merge_target, causing a
use-after-free. Now we save attrs before the merge and restore after.
return falsein remove_if with SDY_CHECK assertion.