Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AxisRefsWithTail instead of ArrayRef of AxisRefs, so the tailing AxisRefAttr can be modified on factor-axis pairs. #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use AxisRefsWithTail instead of ArrayRef of AxisRefs, so the tailing AxisRefAttr can be modified on factor-axis pairs. #205

wants to merge 1 commit into from
+90 −64

Commits on Nov 14, 2024

  1. Use AxisRefsWithTail instead of ArrayRef of AxisRefs, so the tailing … 

    …AxisRefAttr can be modified on factor-axis pairs.

It is to prepare the cases that we consider modified axes to assign to a factor, for example, a trimmed version of the existing axes. For example, if factor i is assigned to {"y":(4)2 }, then some other factor with a sharding {"x", "y", "z"} can now be assigned to {"x", "y":(1)4} and since the tailing axis "y":(1)4 is not in the original sharding sharding {"x", "y", "z"}, it can not be referred using ArrayRef, hence the tailing axis is AxisRefAttr.

This change is no-op, as the tailing axis is always empty.

PiperOrigin-RevId: 696503004
    @Google-ML-Automation @copybara-github
    Google-ML-Automation authored and copybara-github committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    18d923e View commit details
    Browse the repository at this point in the history