Find common axes deterministically by not depending on DenseMap iteration order to find the best factor-axes pair. #208
+78
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…tion order to find the best factor-axes pair. For this, change FactorAxesPair from std::pair to struct, and implement a comparator method, so that factor-axes pairs imposes a total order. It also helps that unit-testing is not flaky. PiperOrigin-RevId: 696603604
copybara-service
bot
force-pushed
the
test_696603604
branch
from
2a11733
to
2a5ed0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find common axes deterministically by not depending on DenseMap iteration order to find the best factor-axes pair.
For this, change FactorAxesPair from std::pair to struct, and implement a comparator method, so that factor-axes pairs imposes a total order.
It also helps that unit-testing is not flaky.