Do not set the sharding of the sharding group op during import, and emit a warning instead of error if the group has a conflicting initial sharding. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…mit a warning instead of error if the group has a conflicting initial sharding. What we should do instead is let propagation resolve what sharding to use. Note this will be a bit arbitrary based on propagation order. We should still at least emit a warning to the user since this is a bit of a weird use of sharding group: ```mlir /tmp/bug.mlir:9:3: warning: Inconsistent shardings prior to propagation for ShardingGroupOps with canonicalized groupId: 0 due to the operand %1 = sdy.sharding_constraint %arg0 <@mesh, [{"a"}, {?}]> : tensor<8x8xf32>. Inserting an open sharding constraint to all constrained values sdy.sharding_group %1 group_id=1183 : tensor<8x8xf32> ^ /tmp/bug.mlir:9:3: note: see current operation: sdy.sharding_group %1 group_id=0 : tensor<8x8xf32> ``` This also matches the behavior in GSPMD. PiperOrigin-RevId: 727888959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set the sharding of the sharding group op during import, and emit a warning instead of error if the group has a conflicting initial sharding.
What we should do instead is let propagation resolve what sharding to use. Note this will be a bit arbitrary based on propagation order. We should still at least emit a warning to the user since this is a bit of a weird use of sharding group:
This also matches the behavior in GSPMD.