Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document open questions in the quantization spec #1408

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Document open questions in the quantization spec #1408

merged 2 commits into from
Apr 18, 2023

Conversation

burmako
Copy link
Contributor

@burmako burmako commented Apr 14, 2023

Following up on #1352, this pull request documents the unresolved conversations from that PR review.

Document open questions in the quantization spec
1d6c7ce 
Following up on #1352, this pull request documents the unresolved
conversations from that PR review.
@burmako burmako added the Spec label Apr 14, 2023
@burmako burmako requested a review from sdasgup3 April 14, 2023 02:17
sdasgup3
sdasgup3 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@sdasgup3 sdasgup3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a comment.

@burmako burmako assigned burmako and unassigned sdasgup3 Apr 17, 2023
@burmako burmako merged commit 4a32703 into openxla:main Apr 18, 2023
@burmako burmako deleted the quant branch April 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdasgup3 sdasgup3 sdasgup3 approved these changes

Assignees

@burmako burmako

Labels
Spec
Projects
Frontend contract
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burmako @sdasgup3