Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cassandra: moves to Apache Driver and fixes Apple Silicon docker crash #3651

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

codefromthecrypt
Copy link
Member

This changes the groupId of the Cassandra driver to Apache as it has been donated by DataStax recently. After upgrading the version, this updates com.github.jnr:jnr-posix to avoid a crash when running the zipkin docker container on Apple Silicon. See apache/cassandra-java-driver#1904

# below crash happens after hitting the /health endpoint on zipkin and it doesn't matter if the cassandra host is present or not.
~ $  STORAGE_TYPE=cassandra3 start-zipkin

                  oo
                 oooo
                oooooo
               oooooooo
              oooooooooo
             oooooooooooo
           ooooooo  ooooooo
          oooooo     ooooooo
         oooooo       ooooooo
        oooooo   o  o   oooooo
       oooooo   oo  oo   oooooo
     ooooooo  oooo  oooo  ooooooo
    oooooo   ooooo  ooooo  ooooooo
   oooooo   oooooo  oooooo  ooooooo
  oooooooo      oo  oo      oooooooo
  ooooooooooooo oo  oo ooooooooooooo
      oooooooooooo  oooooooooooo
          oooooooo  oooooooo
              oooo  oooo

     ________ ____  _  _____ _   _
    |__  /_ _|  _ \| |/ /_ _| \ | |
      / / | || |_) | ' / | ||  \| |
     / /_ | ||  __/| . \ | || |\  |
    |____|___|_|   |_|\_\___|_| \_|

:: version 2.25.1 :: commit 82c3d7a ::

2023-12-15 05:45:58.195  INFO [/] 8 --- [oss-http-*:9411] c.l.a.s.Server                           : Serving HTTP at /0.0.0.0:9411 - http://127.0.0.1:9411/
2023-12-15 05:46:06.887  INFO [/] 8 --- [cking-tasks-2-1] c.d.o.d.i.c.c.CqlPrepareAsyncProcessor   : Adding handler to invalidate cached prepared statements on type changes
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x0000000000005e30, pid=8, tid=59
#
# JRE version: OpenJDK Runtime Environment (21.0.1+12) (build 21.0.1+12-alpine-r1)
# Java VM: OpenJDK 64-Bit Server VM (21.0.1+12-alpine-r1, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-aarch64)
# Problematic frame:
# C  [jffi11042031320136118671.so+0x7f7c]  jffi_throwExceptionByName+0xfc
--snip--

This changes the groupId of the Cassandra driver to Apache as it has
been donated by DataStax recently. After upgrading the version, this
updates com.github.jnr:jnr-posix to avoid a crash when running the
zipkin docker container on Apple Silicon.

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

JDK 11 build hung twice in a row now. Since that's the release build, I'll dig further on it.

@codefromthecrypt codefromthecrypt marked this pull request as draft December 15, 2023 07:44
@codefromthecrypt
Copy link
Member Author

maybe it is javadoc related, as that uses a lot of memory. I stopped running that in the test build.

@codefromthecrypt codefromthecrypt marked this pull request as ready for review December 15, 2023 08:07
@@ -28,7 +28,7 @@ jobs:
matrix: # use latest available versions and be consistent on all workflows!
include:
- java_version: 11 # Last that can compile zipkin core to 1.6 for zipkin-reporter
maven_args: -Prelease -Dgpg.skip
maven_args: -Prelease -Dgpg.skip -Dmaven.javadoc.skip=true
Copy link
Contributor

@anuraaga anuraaga Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget if it's possible to write javadoc that fails to build, in which case this could allow unreleasable code to be merged. But if not an issue should be good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point. deploy doesn't run the tests, but it does build javadoc. I'll raise a PR to add a job that just builds javadoc, so that way it is in parallel also.

@codefromthecrypt codefromthecrypt merged commit 0092696 into master Dec 15, 2023
@codefromthecrypt codefromthecrypt deleted the cassandra-bump branch December 15, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants