docker: uses health check in examples and documents dependencies job #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses health check in the docker-compose examples to reduce the amount of warnings end users see. It also fixes a minor issue on the dependencies job, as well adds instructions for how to run it manually. This is needed for folks who don't want to wait an hour to see the graph. Fixes #3529 Signed-off-by: Adrian Cole <[email protected]>
| in another terminal like so: | ||
|
|
||
| ```bash | ||
| $ docker-compose -f docker-compose-cassandra.yml run --rm --no-deps --entrypoint start-zipkin-dependencies dependencies |
There was a problem hiding this comment.
Thanks @anuraaga for the tip that led to this!
anuraaga
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses health check in the docker-compose examples to reduce the amount of warnings end users see.
It also fixes a minor issue on the dependencies job, as well adds instructions for how to run it manually. This is needed for folks who don't want to wait an hour to see the graph.
Fixes #3529