feature and refactor: add lombok, introduce package structure and add interface to configure dependent resources #208
Conversation
… interface to configure dependent resources (#1) * refactor: add lombok * feature: add interface to configure dependent resources
openshift-ci
bot
added
the
do-not-merge/work-in-progress
| @UtilityClass | ||
| public class ReconcilerRegistrationUtil { | ||
|
|
||
| public List<DependentResourceConfigurator> filterConfigurators(Reconciler<?> reconciler, |
There was a problem hiding this comment.
It might deserve a unit test, since logic is not trivial.
There was a problem hiding this comment.
good point, thank you. added unit tests
| @FunctionalInterface | ||
| public interface DependentResourceConfigurator { | ||
|
|
||
| String getName(); |
There was a problem hiding this comment.
Just one note regarding to this, altevatively we could avoid inheritance, so the configuration bean would not inherit this interface, but we could put here also method getConfiguraiton that would result in the configuration bean.
But no strong opinion one way or another.
There was a problem hiding this comment.
or as an atlernative we could have this just as an annotation on top of a conig bean: @DependentConfiguration(dependentName="dr name", reconcilerName="optional reconciler name")
|
Note: lombok might be a matter of further discussions, but I'm fine also to add it in this PR, just might be removed in the subsequent ones. |
|
Hi @1nval1d , do you still plan to work on this (it is a draft) or we can merge it? |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependentResourceConfig; | ||
| import io.javaoperatorsdk.operator.springboot.starter.DependentResourceConfigurator; | ||
|
|
||
| public class ConfigMapDRConfigurator extends KubernetesDependentResourceConfig<ConfigMap> |
There was a problem hiding this comment.
nit: maybe name it ConfigMapDRConfig
|
@1nval1d are still planning to work on this PR? in case we can merge it to |
BREAKING CHANGE:
Reactoring - introducing new package structure:
basePath: io.javaoperatorsdk.operator.springboot.starter
Introduced new interface to configure dependent resources
Usage: create a bean , that implements the DependentResourceConfigurator interface, return the name of the dependent resource in the getName method. Expect the bean in the configureWith-method of your dependent resource. Make sure to implement other required interfaces.