Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response code REFUSED at Unbound blocklists #7530

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

refuseduser
Copy link

Here is my PR for the addition of response code REFUSED at Unbound blocklists
Ref: #6027
Successfully tested on a live installation

https://github.com/opnsense/core/blob/master/src/opnsense/service/templates/OPNsense/Unbound/core/dnsbl_module.py

  • Since I was already doing this anyway, I added RCODE_SERVFAIL as well as RCODE_REFUSED, as this was used several times but was not defined.
  • Pyflake shows even more undefined variables here, e.g. RR_TYPE_A, but I haven't looked into it any further...

</help>
</field>
<field>
<id>unbound.dnsbl.nxdomain</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a model migration (https://docs.opnsense.org/development/frontend/models_migrations.html#migrations). If you need help with that, we have to postpone the merge for a while (when I have some time to test this myself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants