Added 2FA logic on login screen #8241
Open
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2025
rajiv
reviewed
Jan 23, 2025
rajiv
approved these changes
Jan 24, 2025
|
When can we expect this to merge upstream ? :) |
0xThiebaut
suggested changes
Feb 22, 2025
| if ($showMFAField): ?> | ||
| <div class="form-group"> | ||
| <label for="mfacode"><?= gettext("MFA Code:"); ?></label> | ||
| <input type="text" class="form-control" name="mfacode" id="mfacode" value="" /> |
There was a problem hiding this comment.
Are there cases where MFA wouldn't be a number? Otherwise we might want to improve browser hinting for the auto-completion (e.g., password manager) by adding inputmode="numeric", autocomplete="one-time-code" as well as pattern="\d*".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR : 6310
Added 2FA to Login screen