mvc/view: Ensure fields stay aligned relatively to another when headers are used in forms #8364
Conversation
…rs are used in forms.
Monviech
force-pushed
the
form-dialog-alignment
branch
from
c8e0f40 to
812175b
Compare
|
I'm a bit skeptical having dealt with % width whac-a-mole code changes over the last decade :/ |
… modal-dialog and form-inline exist in the same view (e.g. dnsmasq).
…n msgzone_width is defined (e.g. in Intrusion Detection)
|
I would like the opportunity to whack the mole too :D |
Monviech
force-pushed
the
form-dialog-alignment
branch
from
9242347 to
431544b
Compare
|
Needed to force push this since I accidentally pushed something else in here that belongs to another branch. |
| <colgroup> | ||
| {% if msgzone_width is defined %} |
There was a problem hiding this comment.
Do we even need the msgzone? Seems it's only used by IDS
There was a problem hiding this comment.
I wanted to keep the change backwards compatible. I dont know the reason behind this in IDS.
There was a problem hiding this comment.
these properties should ideally live inside a form metadata tag (or if they're unique cases, handled by javascript), but the scope for that is larger than this change so not worth the effort to look into it here.
|
Let's give this a try then, if there are complains we can always revert it. |
This fixes an issue where introducing headers in forms will botch the alignment of fields because they all spawn their own table. Using relative sizes in the table and colgroup fixes this issue.
This also improves responsiveness of the modal.
Bonus: This also improved how form modals render on mobile devices.