Firewall: Automation filter poc #8377
Draft
+1,510
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uence to auto number field and require uniqueness, split view from filter.volt to filter_rule.volt to test things without causing regressions in other controllers using the same view, construct form with almost same layout as old firewall form hiding most options under advanced that are not needed for creating basic rules, for #8367
…stination and interface. Append icon column to grid. For #8367
…me as the legacy firewall view. For #8367
…es with each other. Change position of the source and destination inversions in form. Replace Port and Sequence labels in Grid view to safe space. Ensure sequence is always ascending and cannot be sortet. For #8367
…the sequence. Animate sequence change. Display Change message on sequence change. For #8367
… the current grid is filtered via category.
…umberField and increments by 10 at the final spot of the sequence. This will ensure new rules will always appear at the end of the ruleset, and there is ample space to move firewall rules inbetween other firewall rules without reordering the whole ruleset if users adhere to the default behavior. Of course, if somebody manually does a sequence without gaps, and the ruleset is large, they will have some fun reordering it by using the move_up and move_down buttons, or rewriting the sequence manually with more space between their rules. This is just a safeguard for the default users who do not want to think much about the sequence.
…ast available sequence number. This helps if a rule is cloned, since the Sequence will be cloned too. Without keeping track, it would be hard to find the last free sequence number. This is not a first in the GUI either, the vhid number in the vip.volt can also be generated like this.
…mn, and always show sequence number.
…osen, in the grid its better to format it as default for Gateway to be in line with the old rule view.
…start counting from 100. Max allowed sequence has been increased to 999999. This allows ample space between rules in all situations.
…ation of Quick before Action, Format Interface with any when none is chosen, Change label of all Invert fields to put invert first
…hem to view, in view we can use them to compare to their default values. If any of the advanced fields are not default, an icon with tooltip appears that shows all non standard fields with their correct translated labels and their values.
… move_down, since it can still move sequences while its filtered, and there is enough feedback with the animations and the changing sequence number to see what happens. If the delta of the rules is far apart, the button just needs to be pressed multiple times. Though its always an option to change the sequence manually.
…re, by using startsWith and toLowerCase we need to track fewer default field states, making it more universal.
…prior generalization of the advanced mode icon, this is all that needs to be done to track advanced rules in the grid.
…nal firewall rules as json
…eters can be passed to either show all rules, or e.g. internal2 or floating.
…which merges internal automatic firewall rules of the legacy implementation into the return of searchRuleBase. It's a little hacky but it works and can be cleaned up later.
…es an error in preg_split in UIModelGrid.php:135
…y data to automation data
…ow these when a row has a valid uuid. Internal rules will not have an UUID, but a string from where they came from, e.g., floating, internal, internal2, groups
…uids the same style but non interactive.
…with contents of #ref
…lays correctly on small screens.
…vate block rules are generated for each interface but kept disabled. This can return a lot of useless rules. Filtering them out makes the returned ruleset more user friendly.
…with contents of #ref, but skip empty ref
…'s easier to read and see changes rather than many rows of any any any any
…ements by 1 again now. But there is a button like in the legacy pages that can move a rule before any other rule. The whole sequence will be recalculated when this option is used. This lessens the burden of micro managing the sequence and makes things clear. This means, the sequence can be now hidden from constant view, since it will be more what you see is what you get. This also enables rules to be moved consistently when filters or search are used, and as long as the sequence is not depleted, things will always automagically work.
…r Gateway, change interface position in grid
…rule by interface. Controller + Selectpicker added.
…lected, and all internal and model rules will be filtered by interface. Category can be filtered additionally afterwards, it matches after the interface filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8367
Opening this as draft to have a better overview of my current state with commits and diff.