net/frr: Integrate layout_partials/base_bootgrid_table #4494
Conversation
Monviech
force-pushed
the
frr-bootgrid-partial
branch
from
1e86ed3 to
4a5feb4
Compare
Monviech
force-pushed
the
frr-bootgrid-partial
branch
from
75295c0 to
ae57a16
Compare
|
As discussed with @AdSchellevis I will also rework the help texts based on the ones I already wrote for the documentation: https://github.com/opnsense/docs/blob/master/source/manual/dynamic_routing.rst |
… are replaced by the proper help texts.
|
@AdSchellevis I'm done here for now. |
There was a problem hiding this comment.
Looks good, one remark, but that's more a know issue reported in opnsense/lang#68. Let's merge this
| (because it will take more than one hop) and to listen on the multihop port (4784). | ||
| When using multi-hop mode echo-mode will not work (see RFC 5883 section 3). | ||
| </help> | ||
| <help>Multihop tells the BFD daemon that we should expect packets with TTL less than 254 (because it will take more than one hop) and to listen on the multihop port (4784). When using multi-hop mode echo-mode will not work (see RFC 5883 section 3).</help> |
There was a problem hiding this comment.
The question is if this is worth the effort as it will break translations (https://github.com/opnsense/lang/blob/fca8fe48bdba970f4560a8c5874e660d4ba53ddb/en_US.pot#L47944-L47951)
Padding unfortunately is still problematic (opnsense/lang#68), we might want to seek a solution for that, but that also means we need to change the existing translations to keep the identifiers matching.
Requires: opnsense/core#8187
Will be one commit per changed volt page.