Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns/ddclient: Added multihost support for cloudflare service #4550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cektom
Copy link
Contributor

@cektom cektom commented Feb 16, 2025

This enables updates for multiple hosts for cloudflare service.
Tested on OPNsense 24.7.11_2

@AdSchellevis
Copy link
Member

I'll leave this open for a bit as some other account types on our end are implemented similarly, but in general there are side affects of iterating hosts like this.

When X hosts are being updated and only one is successfully changed, the service assumes all went file, which isn't the case. By just coping the entries, the recorded state matches reality.

Originally the hostnames implementation was intended for dyndns, which supports multiple names in the same transaction (https://sourceforge.net/p/ddclient/wiki/protocols/#dyndns2)

@cektom
Copy link
Contributor Author

cektom commented Feb 17, 2025

Alright. I checked the API documentation, but unfortunately it is currently not possible to update multiple hostnames at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants