sysutils/git-backup Add ability to hide secret from git backup #4558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since Git backups are not encrypted, they are useful for version control. However, it would be beneficial to have an option to remove sensitive information such as passwords and private keys.
Enabling this option would prevent users from fully restoring the backup, but it would allow for a clear history of changes outside of OPNsense without compromising security—especially considering that even GitLab has had significant CVEs.
Instead of a global option, I could implement a multi-select button to choose which types of sensitive data to hide.
Additionally, I could restrict specific paths for certain fields, such as private keys for certificates instead of the global prv field.
While encrypting the entire file is an option, it would make it impossible to track differences between versions. Let me know your thoughts!