Skip to content

Make "Create a Good PR" tutorial #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
U8NWXD opened this issue Aug 26, 2024 · 4 comments · May be fixed by #457
Open

Make "Create a Good PR" tutorial #356

U8NWXD opened this issue Aug 26, 2024 · 4 comments · May be fixed by #457
Assignees
Labels

Comments

@U8NWXD
Copy link
Member

U8NWXD commented Aug 26, 2024

This tutorial should be comprehensive, and then https://github.com/oppia/oppia/wiki/Make-a-pull-request can become the same content in a reference-like format. The tutorial could reference sections of https://github.com/oppia/oppia/wiki/Make-a-pull-request as well and talk more about "how to follow those instructions" (e.g. how to write a good PR description).

@LittleRainC
Copy link

Hi, may I work on this? I'm going to link a new page like this under "Make your first PR". Here is how it looks like:

Image

Image

Image

Image

Image

@seanlip
Copy link
Member

seanlip commented Apr 25, 2025

@LittleRainC This is really quite nice, and I like the positive framing! I'm assigning you, feel free to go ahead and make a PR for it. Thanks!

@LittleRainC
Copy link

Thanks! PR been created -> #457

@LittleRainC
Copy link

@seanlip Hi, I have made PR, let me now if it is good when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants