Skip to content

Fix #356: Make "Create a Good PR" tutorial #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix #356: Make "Create a Good PR" tutorial #457

wants to merge 5 commits into from

Conversation

LittleRainC
Copy link

Fix #356: Make "Create a Good PR" tutorial -> Make "Create a Good PR" tutorial.

Changed files:

  • Add a "Create a Good PR" file - add the page of it
  • Siderbar.md - add a link for "Create a Good PR" under "Making your first PR" - "Rules for making PRs"

image
image
image
image
image

@LittleRainC
Add "Create a Good PR" file
3df411b
@LittleRainC
Update _Sidebar.md
8eeaa12 
add "Create a Good PR" under "Making your first PR"
@LittleRainC
Update Create a Good PR.md
48f6f19 
Add table of content part
@LittleRainC LittleRainC mentioned this pull request Apr 28, 2025
Open
seanlip
seanlip requested changes May 1, 2025
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LittleRainC! Left some notes, PTAL.

LittleRainC added 2 commits May 1, 2025 00:28
@LittleRainC
Update _Sidebar.md
1b77d8f 
Moved the learning resources for developers to the "getting started" section above. Adjusted the structure of makings PRs.
@LittleRainC
Update Create a Good PR.md
d16a847 
1. Added space between "Pull Request" and "(PR)" in first sentence
2. Added a refer to the more detailed "PR guide" at some point
3. Used a checklist format - [ ] 
4. Linked the relevant github discussions category
5. Removed the "Ask in Oppia’s chat or community channels".
@LittleRainC LittleRainC requested a review from seanlip May 1, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip Awaiting requested review from seanlip

Requested changes must be addressed to merge this pull request.

Assignees

@LittleRainC LittleRainC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "Create a Good PR" tutorial
2 participants
@LittleRainC @seanlip