-
Notifications
You must be signed in to change notification settings - Fork 7
IHS-176: Remove is_visible property from attribute metadata
#603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR removes `is_visible` property from attribute metadata.
WalkthroughThe pull request removes the Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
2bfa7b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c66f498e.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://sb-20251107-remove-metadata.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #603 +/- ##
===========================================
- Coverage 76.44% 75.57% -0.87%
===========================================
Files 112 113 +1
Lines 10856 9508 -1348
Branches 2335 1447 -888
===========================================
- Hits 8299 7186 -1113
+ Misses 1982 1835 -147
+ Partials 575 487 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
This PR should target |
I think either or would be fine in this case as IS_VISIBLE was never really used and even if you update the property it doesn't do anything sensible. |
|
@solababs, can we add a news fragment of the "removed" kind and just mention that the SDK will no longer query for the is_visible property as that's being phased out of Infrahub? |
This PR removes
is_visibleproperty from attribute metadata.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.