-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready To Merge] Adds supporting of the OpenAI and AsyncOpenAI Clients #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayoor
approved these changes
Apr 2, 2025
VipulMascarenhas
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new client classes—AquaOpenAI (synchronous) and AsyncAquaOpenAI (asynchronous)—that extend the official OpenAI Python SDK to support OCI-AQUA-based model deployments. The changes are aimed at making our integration with OCI seamless and future‑proof by dynamically patching request headers and normalizing URL paths based on the deployment OCID.
Out Of Scope
OpenAI recently introduced a new API, but VLLM does not support it yet. For more details, refer to this issue. The
AquaOpenAIClient
can be enhanced to support the new OpenAI specification once VLLM adds compatibility.Key Features
Common Request Patching Logic:
AquaAIMixin
) encapsulates all common logic for patching request headers and normalizing URL paths."route"
header dynamically./chat/completions
,/embeddings
, etc.) is replaced with/predict
."enable-streaming"
header based on whether the request JSON body contains"stream": true
.Auto-Creation of HTTP Clients:
ads.aqua.get_httpx_client()
.httpx.AsyncClient
usingads.aqua.get_async_httpx_client()
.Support for Both Sync and Async Workflows:
AquaOpenAI
andAsyncAquaOpenAI
inherit from their respective OpenAI base classes and from the common mixin.Testing
Sync
Async