[Multi model deployment] Updating usages for container config #1144
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-shivam-ranjan
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
VipulMascarenhas
previously approved these changes
Apr 2, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
reviewed
Apr 2, 2025
ads/aqua/config/container_config.py
Outdated
| @@ -14,7 +14,7 @@ | |||
| class Usage(ExtendedEnum): | |||
| INFERENCE = "inference" | |||
| BATCH_INFERENCE = "batch_inference" | |||
| MULTI_MODEL = "multi_model" | |||
| MULTI_MODEL = "other" | |||
There was a problem hiding this comment.
I would prefer to have other as temporary solution. I would suggest to keep them both:
class Usage(ExtendedEnum):
INFERENCE = "inference"
BATCH_INFERENCE = "batch_inference"
MULTI_MODEL = "multi_model"
OTHER = "other"
Then in the code we will have to do something like this:
supported_container_families = [
container_config_item.family
for container_config_item in service_inference_containers
if any(usage in container_config_item.usages for usage in [Usage.MULTI_MODEL, Usage.OTHER])
]
I assume we will use the proper name in the future.
There was a problem hiding this comment.
Updated. Thanks
mrDzurb
approved these changes
Apr 2, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to update the
Usageenum for multi model deployment to unblock DRCC feature adoption.Dependent PR
https://bitbucket.oci.oraclecorp.com/projects/ODSC/repos/odsc_artifact_deployer/pull-requests/260/overview
Unit tests