Adds VLLM LLaMA 4 support to the list of compatible container families for Multi-Model deployment. #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrDzurb
requested review from
darenr,
mayoor,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
| @@ -380,7 +386,8 @@ def create_multi( | |||
| raise AquaValueError( | |||
| "The selected models are associated with different container families: " | |||
| f"{list(selected_models_deployment_containers)}." | |||
| "For multi-model deployment, all models in the group must share the same container family." | |||
| "For multi-model deployment, all models in the group must belong to the same container " | |||
| "family or to compatible container families." | |||
There was a problem hiding this comment.
nit: "two" instead of "to"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds VLLM LLaMA 4 support to the list of compatible container families for Multi-Model deployment.