feat: add MLE application template #257
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| # Database User Password | ||
| DB_PASSWORD=<%= connectionPassword %> | ||
| # Connection string to your Autonomous Database/ | ||
| # Oracle Database Free instance |
There was a problem hiding this comment.
This might create confusion for users since the connection will not necessarily be to a free DB instance.
| # Connection string to your Autonomous Database/ | ||
| # Oracle Database Free instance | ||
| CONNECT_STRING=<%= connectionString %> | ||
| MLE_MODULE= |
There was a problem hiding this comment.
This variable is empty and does not have a replacement token, is this expected?
| @@ -207,7 +207,7 @@ export default class Generate extends Command { | |||
| 'template': Flags.string({ | |||
| char: 't', | |||
| description: 'Template to use', | |||
| options: ['node-vanilla', 'node-react', 'node-vue', 'node-react-todo', 'node-jet', 'node-angular', 'ords-remix-jwt-sample'], | |||
| options: ['node-vanilla', 'node-react', 'node-vue', 'node-react-todo', 'node-jet', 'node-angular', 'ords-remix-jwt-sample', 'mle-js-basic'], | |||
There was a problem hiding this comment.
I think we need to adjust the template name to have consistency with other templates and be more explicit on it's main functionality, a few proposals I have in mind:
mle-ts-samplemle-deployment-samplemle-todomle-todo-sample
| @@ -188,3 +188,8 @@ updates: | |||
| - "templates-ords-remix" | |||
| commit-message: | |||
| prefix: fix(deps) | |||
|
|
|||
| - package-ecosystem: "npm" | |||
| directory: "/templates/mle-js-basic/" | |||
There was a problem hiding this comment.
When the template name is defined, I'll create a label on the project so that PRs created by dependabot can be easily filtered.
This will require a minor change here, but let's define that other item first.
| } | ||
|
|
||
| console.log(`Executing: ${filePath}...`); | ||
| const sqlclCommand = `"${sqlExecutable}" -S /nolog <<'EOF' |
There was a problem hiding this comment.
Regarding SQLcl, one of the concerns raised when discussing with the team is the fact that this:
- This adds external dependencies.
- Users who are not used to the Oracle ecosystem will probably not have SQLcl installed on their system, which represents a barrier to the use of the template.
- We should explore the possibility of performing deployments using the
node-oracledbdriver as other templates do in the project for the DB connection.
For additional context: the objective of this generator is to help newcomers to the Oracle ecosystem by automating repetitive boilerplate tasks, eliminating setup friction, and accelerating onboarding, that why SQLcl is a concern for us.
| "scripts": { | ||
| "build": "esbuild src/index.ts --bundle --minify=false --platform=neutral --format=esm --outfile=dist/index.js", | ||
| "deploy": "node deploy.mjs", | ||
| "initdb": "node utils/db.mjs utils/database/initdb.sql", |
There was a problem hiding this comment.
How does initdb handle the case where objects are already in the DB but the cleandb has not been run?
[PR] [Enhancement] MLE application template #255