Start Oracle Database health check only after startup is finished #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
felipecrs
force-pushed
the
healthcheck-wait-for-scripts
branch
5 times, most recently
from
3c428ff to
0de46e6
Compare
felipecrs
changed the title
|
To be fair, the linter is complaining about (real) issues but not related with my code. I can still fix them if you want. |
felipecrs
changed the title
felipecrs
force-pushed
the
healthcheck-wait-for-scripts
branch
from
0de46e6 to
40a875a
Compare
felipecrs
changed the title
|
@felipecrs can we fix the lint errors and resolve the conflicts please |
…ealthcheck-wait-for-scripts
felipecrs
force-pushed
the
healthcheck-wait-for-scripts
branch
from
10a3e4e to
fb854eb
Compare
|
@yunus-qureshi, done. Please check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Oracle Database for some of our CI testing, both via
docker-composeand Kubernetes, relying on Oracle’s health check to determine when the database is ready for the application to connect.Our process involves creating users and tables through an
init_db.shscript, which runs atstartup(not atsetup), since we leverage theprebuiltdbextension. Therefore, it's crucial that the application only attempts to connect once the database is fully initialized, and all startup scripts have executed.The current health check only verifies if the database is running, without considering whether the initialization logic has finished. This can result in race conditions where the application tries to connect before the database is fully started.
This PR aims to resolve that by introducing a marker file, which signals that the database has completed its startup process. Only after this file is present the health checker will attempt to connect to the database.
So, what do you think?