Skip to content

fix(jetty-client:12.0.0.beta0): resolve test failures #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

fix(jetty-client:12.0.0.beta0): resolve test failures #601

merged 2 commits into from
Apr 11, 2025

Conversation

erguiti-imane
Copy link
Member

What does this PR do?

  • Updated the version of 'org.eclipse.jetty:jetty-client' to 11.0.12 in the testImplementation scope and regenerated metadata.

Checklist before merging

@erguiti-imane erguiti-imane requested a review from a team as a code owner February 19, 2025 17:36
@dnestoro
Copy link
Member

dnestoro commented Mar 3, 2025

@fniephaus please review this pull request when possible as we are planning to have a new release of reachability metadata (+Native Build Tools) soon.

@fniephaus fniephaus requested review from mhalbritter and dnestoro and removed request for fniephaus March 3, 2025 15:51
dnestoro
dnestoro reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@dnestoro dnestoro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Thanks for your contribution! I just added few minor comments. Please address them and resolve current merge conflicts.

@mhalbritter please review this PR since you added initial metadata and tests for jetty-client

tests/src/org.eclipse.jetty/jetty-client/12.0.0.beta0/build.gradle
graalvmNative {
binaries {
test {
buildArgs.add('--enable-preview')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you use this build arg?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build arg was already in use in previous tests, so I kept it. The test class uses String.formatted(), which was a preview feature in Java 15 before becoming standard in Java 17. Keeping --enable-preview just ensures everything runs smoothly across different Java versions

mhalbritter
mhalbritter requested changes Mar 5, 2025
View reviewed changes
@mhalbritter
Copy link
Collaborator

Hello, i've left some remarks.

@erguiti-imane erguiti-imane force-pushed the jetty-client/fix-12.0.0.beta0 branch from 1779ea0 to 78c15b0 Compare March 26, 2025 00:59
@erguiti-imane
fix(jetty-client:12.0.0.beta0): resolve test failures
f1b09be 
- Updated the version of 'org.eclipse.jetty:jetty-client' to 11.0.12 in the testImplementation scope and regenerated metadata.
@erguiti-imane
Update Jetty client dependency and clean up source-config.json
ccb77f3
@erguiti-imane erguiti-imane force-pushed the jetty-client/fix-12.0.0.beta0 branch from 78c15b0 to ccb77f3 Compare March 26, 2025 01:43
@dnestoro
Copy link
Member

dnestoro commented Apr 7, 2025

@erguiti-imane @mhalbritter since all conversations are resolved, can we proceed with reviewing/merging this pull request?

@mhalbritter
Copy link
Collaborator

Fine from my side.

@erguiti-imane
Copy link
Member Author

fine from my side as well.

@dnestoro dnestoro requested a review from mhalbritter April 7, 2025 13:56
@dnestoro dnestoro merged commit 5009f20 into oracle:master Apr 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhalbritter mhalbritter mhalbritter approved these changes

@dnestoro dnestoro dnestoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erguiti-imane @dnestoro @mhalbritter