-
Notifications
You must be signed in to change notification settings - Fork 19
"Bring your own vnet" for Application Gateway on AKS offer #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Successful workflow: https://github.com/galiacheng/weblogic-azure/actions/runs/2427220946 |
508a44f
to
3537ca6
Compare
appGatewaySubnetId=$(az network application-gateway show -g ${curRGName} --name ${appgwName} -o tsv --query "gatewayIpConfigurations[0].subnet.id") | ||
appGatewayVnetResourceGroup=$(az network application-gateway show -g ${curRGName} --name ${appgwName} -o tsv --query "gatewayIpConfigurations[0].subnet.resourceGroup") | ||
appGatewaySubnetName=$(az resource show --ids ${appGatewaySubnetId} --query "name" -o tsv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not going to hold up the commit for this comment, but I would like to ask @galiacheng if they judge it is appropriate to undertake an audit of the existing shell scripts in this offer and make them comply with the best practices shown in articles such as this? If so, please file a User Story in our internal tracker and we can prioritize and schedule that work. If not, please let me know why not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @edburns see user story
…rontend ip. Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_appgateway.bicep new file: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_vnetAppGateway.bicep
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/appgw-helm-config.yaml.template modified: weblogic-azure-aks/src/main/arm/scripts/createAppGatewayIngress.sh
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_appgateway.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json
Signed-off-by: galiacheng <[email protected]> Changes to be committed: new file: weblogic-azure-aks/src/main/arm/scripts/inline-scripts/queryPrivateIPForAppGateway.sh modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_appgateway.bicep new file: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds_query_available_private_ip_from_subnet.bicep modified: weblogic-azure-aks/src/main/bicep/modules/networking.bicep
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/inline-scripts/queryPrivateIPForAppGateway.sh modified: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds_query_available_private_ip_from_subnet.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/common.sh modified: weblogic-azure-aks/src/main/arm/scripts/createAppGatewayIngress.sh
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]> Changes not staged for commit: modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: src/main/bicep/modules/_azure-resoruces/_appgateway.bicep modified: src/main/bicep/modules/networking.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep
modified: weblogic-azure-aks/pom.xml - Increment pom. modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json - Trivial wording changes. Signed-off-by: Ed Burns <[email protected]>
3537ca6
to
479e46d
Compare
Signed-off-by: galiacheng <[email protected]> Changes to be committed: new file: weblogic-azure-aks/src/main/arm/scripts/inline-scripts/queryPrivateIPForAppGateway.sh modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_appgateway.bicep new file: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds_query_available_private_ip_from_subnet.bicep modified: weblogic-azure-aks/src/main/bicep/modules/networking.bicep
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/inline-scripts/queryPrivateIPForAppGateway.sh modified: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds_query_available_private_ip_from_subnet.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/common.sh modified: weblogic-azure-aks/src/main/arm/scripts/createAppGatewayIngress.sh
Signed-off-by: galiacheng <[email protected]>
Signed-off-by: galiacheng <[email protected]> Changes not staged for commit: modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: src/main/bicep/modules/_azure-resoruces/_appgateway.bicep modified: src/main/bicep/modules/networking.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep
modified: weblogic-azure-aks/pom.xml - Increment pom. modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json - Trivial wording changes. Signed-off-by: Ed Burns <[email protected]>
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: src/main/arm/createUiDefinition.json
…nition Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: src/main/bicep/mainTemplate.bicep modified: src/main/bicep/modules/_azure-resoruces/_appgateway.bicep modified: src/main/bicep/modules/_azure-resoruces/_vnetAppGateway.bicep modified: src/main/bicep/modules/_deployment-scripts/_ds-validate-parameters.bicep modified: src/main/bicep/modules/_deployment-scripts/_ds_query_available_private_ip_from_subnet.bicep modified: src/main/bicep/modules/networking.bicep
…vaults/2021-10-01 Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: src/main/bicep/mainTemplate.bicep modified: src/main/bicep/modules/_azure-resoruces/_keyvault/_keyvaultForGatewayBackendCert.bicep modified: src/main/bicep/modules/_azure-resoruces/_keyvault/_keyvaultForWLSSSLCert.bicep modified: src/main/bicep/modules/_azure-resoruces/_keyvault/_keyvaultWithExistingCert.bicep modified: src/main/bicep/modules/_azure-resoruces/_keyvault/_keyvaultWithNewCert.bicep modified: src/main/bicep/modules/networking.bicep
…erRegistry/registries/2021-09-01 Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: src/main/bicep/modules/_azure-resoruces/_acr.bicep
Type Mismatch: Parameter 'wlsIdentityKeyStoreData' in nested tem plate 'wls-domain-deployment' is defined as string, but the parent template def ines it as secureString). Line: 4883, Column: 22 Type Mismatch: Parameter 'wlsPrivateKeyAlias' in nested temp late 'wls-domain-deployment' is defined as string, but the parent template defi nes it as secureString). Line: 4914, Column: 22 Type Mismatch: Parameter 'wlsTrustKeyStoreData' in nested te mplate 'wls-domain-deployment' is defined as string, but the parent template de fines it as secureString). Line: 4922, Column: 22 Type Mismatch: Parameter 'wlsIdentityKeyStoreData' in nested template 'wls-domain-deployment' is defined as string, but the parent template defines it as secureString). Line: 3330, Column: 22 Type Mismatch: Parameter 'wlsPrivateKeyAlias' in nested temp late 'wls-domain-deployment' is defined as string, but the parent template defi nes it as secureString). Line: 3361, Column: 22 Type Mismatch: Parameter 'wlsTrustKeyStoreData' in nested te mplate 'wls-domain-deployment' is defined as string, but the parent template de fines it as secureString). Line: 3369, Column: 22 Type Mismatch: Parameter 'wlsIdentityKeyStoreData' in nested template 'setup-wls-cluster' is defined as secureString, but the parent templa te defines it as string). Line: 2511, Column: 14 Type Mismatch: Parameter 'wlsPrivateKeyAlias' in nested temp late 'setup-wls-cluster' is defined as secureString, but the parent template de fines it as string). Line: 2548, Column: 14 Type Mismatch: Parameter 'wlsTrustKeyStoreData' in nested te mplate 'setup-wls-cluster' is defined as secureString, but the parent template defines it as string). Line: 2556, Column: 14Type Mismatch: Parameter 'wlsIdentityKeyStoreData' in nested tem plate 'wls-domain-deployment' is defined as string, but the parent template def ines it as secureString). Line: 4883, Column: 22 Type Mismatch: Parameter 'wlsPrivateKeyAlias' in nested temp late 'wls-domain-deployment' is defined as string, but the parent template defi nes it as secureString). Line: 4914, Column: 22 Type Mismatch: Parameter 'wlsTrustKeyStoreData' in nested te mplate 'wls-domain-deployment' is defined as string, but the parent template de fines it as secureString). Line: 4922, Column: 22 Type Mismatch: Parameter 'wlsIdentityKeyStoreData' in nested template 'wls-domain-deployment' is defined as string, but the parent template defines it as secureString). Line: 3330, Column: 22 Type Mismatch: Parameter 'wlsPrivateKeyAlias' in nested temp late 'wls-domain-deployment' is defined as string, but the parent template defi nes it as secureString). Line: 3361, Column: 22 Type Mismatch: Parameter 'wlsTrustKeyStoreData' in nested te mplate 'wls-domain-deployment' is defined as string, but the parent template de fines it as secureString). Line: 3369, Column: 22 Type Mismatch: Parameter 'wlsIdentityKeyStoreData' in nested template 'setup-wls-cluster' is defined as secureString, but the parent templa te defines it as string). Line: 2511, Column: 14 Type Mismatch: Parameter 'wlsPrivateKeyAlias' in nested temp late 'setup-wls-cluster' is defined as secureString, but the parent template de fines it as string). Line: 2548, Column: 14 Type Mismatch: Parameter 'wlsTrustKeyStoreData' in nested te mplate 'setup-wls-cluster' is defined as secureString, but the parent template defines it as string). Line: 2556, Column: 14 Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: src/main/bicep/modules/_azure-resoruces/_keyvault/_keyvaultForWLSSSLCert.bicep modified: src/main/bicep/modules/_deployment-scripts/_ds-create-wls-cluster.bicep
…ed 'vnetForApplicationGateway' must output the newOrExisting property when hideExisting is false Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_vnetAppGateway.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/inline-scripts/validateParameters.sh modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_appgateway.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-create-networking.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-validate-parameters.bicep modified: weblogic-azure-aks/src/main/bicep/modules/networking.bicep modified: weblogic-azure-aks/src/main/bicep/modules/setupWebLogicCluster.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: .github/workflows/buildWlsAksArtifact.yml modified: .github/workflows/testWlsAksWithDependencyCreation.yml modified: .github/workflows/testWlsAksWithoutDependencyCreation.yml
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/common.sh
The new version of Azure CLI `az ad sp create-for-rbac` requires specifying `--scope` if `--role` is specified.
The new version of Azure CLI `az ad sp create-for-rbac` requires specifying `--scope` if `--role` is specified. Fix wording for 'confirm service principal'.
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: ../arm/createUiDefinition.json
fb8c3d8
to
7c2b87c
Compare
Signed-off-by: galiacheng <[email protected]> Changes to be committed: deleted: src/resources/ejb-client-stateless-1.0.0.war deleted: src/resources/ejb-server-stateless-1.0.0.jar
…-azure into private-vnet-support
Current aks offer covers "Bring your own VNET" for AKS cluster by bringing existing AKS cluster, while it does not support "Bring your own VNET" for Application Gateway, this PR is to support VNET customization for Application Gateway.
Contents
Requirements
For quick start and quick validation
For enterprise workload migration/POC
Current offer supports R1, this pr will enable R2-R4.
VNET scenarios that the offer will support after this PR merged
Note: custom T3 is disabled from UI definition, customer is able to enable custom T3 with advanced deployment using the templates, so the diagrams include T3/T3s access to WebLogic Server.
AKS and Application Gateway are in the same VNET:

AKS and Application Gateway are in different VNET:

Test cases
Validating private access
The following steps are to validate the WLS cluster accessibility that is exposed to internal network using private IP. If you expose the cluster via public IP, just test it from your browser, need not follow the steps.
Deploy offer and enable application gateway with private frontend IP:
Get deployment output: clusterExternalUrl (e.g. http://10.3.0.4/), the application url is ${clusterExternalUrl}testwebapp/ (e.g. http://10.3.0.4/testwebapp/)
There are two approaches to access the application: using kubectl exec or a jump box. You can choose one of them to test the feature.
Validate cluster accessibility from Admin Pod
az aks get-credentials --resource-group haiche-private-vnet-5 --name wlsonaks1ea3ptpccopio4
kubectl exec -it <admin-pod-name> -n <wls-namespace> -- /bin/bash -c "${applicationUrl}"
Admin Pod and Application Gateway are in the same VNET (VNET peering), should be able to access Application Gateway Url.
Access WLS cluster with jump box
haiche-jump-box
wlsaks-vnet
, e.g.wlsaks-vnet12345678