Fix unfalsifiable tests that swallow assertion failures#1199
Open
Asher- wants to merge 3 commits intooraios:mainfrom
Open
Fix unfalsifiable tests that swallow assertion failures#1199Asher- wants to merge 3 commits intooraios:mainfrom
Asher- wants to merge 3 commits intooraios:mainfrom
Conversation
…kit-lsp sourcekit-lsp was launched with no arguments, giving it no location to store its background index. Without --scratch-path, textDocument/references always returns empty because there is no index store for cross-file symbol resolution. - Pass --scratch-path <repo>/.build/sourcekit-lsp when launching - Increase local indexing delay from 5s to 10s (real projects need more time) - Add retry logic for local runs when references are empty, not just CI Fixes root cause of issue oraios#876. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
On macOS, bare sourcekit-lsp resolves to Command Line Tools version which has limited indexing capabilities. xcrun without DEVELOPER_DIR also resolves to CLT. Setting DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer gives the full Xcode sourcekit-lsp with proper background indexing support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- test_request_defining_symbol_method_call: Remove try/except that caught AssertionError and replaced it with warnings.warn(), making the test unable to fail. - test_request_defining_symbol_nested_function: Remove duplicated Test 2 and Test 3 blocks (first copy swallowed errors, second was strict). Keep only the strict version. - test_symbol_methods_integration: Replace exception-swallowing container hierarchy check with an actual assertion that fails if UserService class is not found. - Vue error case tests (4 tests): Replace `except (FileNotFoundError, Exception)` with `except FileNotFoundError`. The broad Exception catch swallowed AssertionError from the try-branch assertions, making them unreachable on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several tests catch
AssertionErroror use overly broad exception handlers, making them unable to detect regressions:test_request_defining_symbol_method_call: CaughtAssertionErrorand replaced withwarnings.warn().test_request_defining_symbol_nested_function: Had duplicated Test 2/Test 3 blocks — first copy swallowed errors, second was strict.test_symbol_methods_integration: Container hierarchy check caught all exceptions silently.Vue error case tests (4 tests): Used
except (FileNotFoundError, Exception)which catches everything includingAssertionError, making the try-branch assertions unreachable on failure.Fix
except AssertionError: warnings.warn(...)— let assertions fail.except FileNotFoundErroronly.Note
These tests may now fail if they were masking real regressions. That's the intended behavior — tests should detect failures, not hide them.
Verification