make oras-py behave the same way as oras-go for deciding whether to unpack a layer #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…npack a tar layer or not Signed-off-by: Michael Kopf <[email protected]>
Signed-off-by: Michael Kopf <[email protected]>
|
This is great! I think I might have been involved with at least requesting / discussing the feature: oras-project/oras-go#644 I'm waiting for #171 to finish, then likely we will want to merge and rebase off of that. If they work together they can go into the same release (and we can just update the changelog to indicate that). |
|
okay merged #171 - please rebase here and then we will test. |
|
hi @vsoch |
|
Please see #179. Do you want a rebase or is regular pull+merge okay? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #119
use the same logic as oras-go and cli for determining whether to unpack a tar layer or not.
With this implementation oras-py does not anymore use the layer's media type, it uses the annotation io.deis.oras.content.unpack.
that way artifacts published by oras-cli can be consumed the same way with oras-py and vice versa.
in addition, a skip_unpack param was added to the pull command in favor of #119