Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static): add human readable option for Static/Section headers/ Size #96

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dacianpascu06
Copy link
Contributor

Description of change

Readability feature now works for Static Tab / Section headers /Size as well.

How has this been tested? (if applicable)

Verified the program to correctly toggle human readable on and off only on tab StaticAnalysis.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 3.30%. Comparing base (419feae) to head (1628d46).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/elf/header.rs 0.00% 7 Missing ⚠️
src/tui/state.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #96      +/-   ##
========================================
- Coverage   3.31%   3.30%   -0.00%     
========================================
  Files         19      19              
  Lines       2419    2426       +7     
========================================
  Hits          80      80              
- Misses      2339    2346       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orhun orhun merged commit 09137d2 into orhun:main Oct 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants