fix: display correct amount of duplicate schemas #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
Mar 2, 2025
cscovino
pushed a commit
to cscovino/orval
that referenced
this pull request
Mar 3, 2025
feat(core): ✏️ add naming convention option to output
melloware
pushed a commit
that referenced
this pull request
Mar 3, 2025
* fix: display correct amount of duplicate schemas (#1958) feat(core): ✏️ add naming convention option to output * fix(core): 🐛 apply naming convention to target files --------- Co-authored-by: Alice Jonsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Duplicate schema names were showing one less than the actual number of schemas (e.g. showing
1xinstead of2xwhen there were 2 schemas with the same name)Another thought is that we should probably detect duplicate schemas even if
indexFilesis set tofalse, but that breaks the (unsafe) workaround mentioned in #1733Steps to Test or Reproduce
petstore.yaml:email: type: string format: email + calling_code: + type: number + enum: [1, 2, 3] callingCode: type: string enum: ['+33', '+420', '+33'] # intentional duplicated value