Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update quickstart to use tunnel #2096

Merged
merged 24 commits into from
Apr 9, 2025
Merged

docs: update quickstart to use tunnel #2096

merged 24 commits into from
Apr 9, 2025

Conversation

christiannwamba
Copy link
Contributor

@christiannwamba christiannwamba commented Apr 3, 2025

closes #845

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr
Copy link
Member

aeneasr commented Apr 4, 2025

These tests seem to be failing because we now use the tunnel and not the proxy and it looks like the flows aren't working as intended. You can run these tests locally as well, here are the steps:

https://github.com/ory/docs/blob/master/.github/workflows/playwright.yml

aeneasr
aeneasr previously requested changes Apr 7, 2025
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-07 at 10 23 17

@aeneasr
Copy link
Member

aeneasr commented Apr 7, 2025

I see review hast ben re-requested, but the preview looks the same for me

@christiannwamba
Copy link
Contributor Author

Thanks @aeneasr. Looks like the make format is fighting with markdown syntax. Let me find a way around it

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, that is a pretty big change and has been a long time coming!
There are a few smaller things to smooth out but we are almost there.
I want to make sure that we catch everything, so it might be a bit nitpicky. Almost there ✌️

@christiannwamba
Copy link
Contributor Author

Thanks @vinckr. Resolved all your feedback now. You can take another look.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once the conflict is resolved we can merge

@christiannwamba christiannwamba requested a review from vinckr April 9, 2025 20:29
@vinckr vinckr merged commit a1c2b6f into master Apr 9, 2025
9 checks passed
@vinckr vinckr deleted the deprecate-proxy branch April 9, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Protect Login page examples with new CLI commands
3 participants