-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update quickstart to use tunnel #2096
Conversation
These tests seem to be failing because we now use the tunnel and not the proxy and it looks like the flows aren't working as intended. You can run these tests locally as well, here are the steps: https://github.com/ory/docs/blob/master/.github/workflows/playwright.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see review hast ben re-requested, but the preview looks the same for me |
Thanks @aeneasr. Looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, that is a pretty big change and has been a long time coming!
There are a few smaller things to smooth out but we are almost there.
I want to make sure that we catch everything, so it might be a bit nitpicky. Almost there ✌️
Thanks @vinckr. Resolved all your feedback now. You can take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, once the conflict is resolved we can merge
closes #845
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments