Skip to content

feat(configx): default otel sampling rate to 1 #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthewhughes-uw
Copy link

This puts OTEL in line with the jaeger config. The motivation for this was the time spent debugging why no traces were being sent from a pod running oryd/hydra with our basic config:

tracing:
  provider: otel
  service_name: ory-hydra
  deployment_environment: development
  providers:
    otlp:
      server_url: our-collector:4318
      insecure: true

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2025

CLA assistant check
All committers have signed the CLA.

This puts OTEL in line with the jaeger config. The motivation for this
was the time spent debugging why no traces were being sent from a pod
running `oryd/hydra` with our basic config:

    tracing:
      provider: otel
      service_name: ory-hydra
      deployment_environment: development
      providers:
        otlp:
          server_url: our-collector:4318
          insecure: true
@matthewhughes-uw matthewhughes-uw force-pushed the non-zero-otel-sampling-default branch from 91a7f5a to 1e46305 Compare March 27, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants