Wizard: Disk customization (HMS-8945)

playwright/Customizations/Disk.spec.ts

@@ -0,0 +1,273 @@
+import * as fsPromises from 'fs/promises';
+import * as path from 'path';
+
+import { expect } from '@playwright/test';
+import { v4 as uuidv4 } from 'uuid';
+
+import { test } from '../fixtures/cleanup';
+import { isHosted } from '../helpers/helpers';
+import { ensureAuthenticated } from '../helpers/login';
+import {
+  fillInImageOutput,
+  ibFrame,
+  navigateToLandingPage,
+} from '../helpers/navHelpers';
+import {
+  createBlueprint,
+  deleteBlueprint,
+  exportBlueprint,
+  fillInDetails,
+  fillInImageOutputGuest,
+  importBlueprint,
+  registerLater,
+} from '../helpers/wizardHelpers';
+
+test('Create a blueprint with Disk customization', async ({
+  page,
+  cleanup,
+}) => {
+  const blueprintName = 'test-' + uuidv4();
+
+  // Delete the blueprint after the run fixture
+  await cleanup.add(() => deleteBlueprint(page, blueprintName));
+
+  await ensureAuthenticated(page);
+
+  // Login, navigate to IB and get the frame
+  await navigateToLandingPage(page);
+  const frame = await ibFrame(page);
+
+  await test.step('Navigate to optional steps in Wizard', async () => {
+    await fillInImageOutput(frame);
+    await registerLater(frame);
+  });
+
+  await test.step('Check basic structure of advanced partitioning', async () => {
+    await frame
+      .getByRole('button', { name: 'File system configuration' })
+      .click();
+    await frame
+      .getByRole('radio', { name: 'Advanced disk partitioning' })
+      .click();
+
+    // Temporarily disabled - need to confirm if `auto-lvm` radio should be added
+    // const rawPartitioningRadio = frame.getByRole('radio', {
+    //   name: /raw partitioning/i,
+    // });
+    // await expect(rawPartitioningRadio).toBeVisible();
+    // await expect(rawPartitioningRadio).toBeChecked();
+
+    await expect(frame.getByRole('button', { name: '/' })).toBeDisabled();
+    await expect(
+      frame.getByRole('row').nth(1).getByRole('button').nth(4),
+    ).toBeEnabled();
+
+    await expect(
+      frame.getByRole('button', {
+        name: /add plain partition/i,
+      }),
+    ).toBeVisible();
+    await expect(
+      frame.getByRole('button', {
+        name: /add lvm volume group/i,
+      }),
+    ).toBeVisible();
+  });
+
+  await test.step('Fill in some partitions and add a volume group', async () => {
+    await frame.getByRole('button', { name: 'Add plain partition' }).click();
+    await frame.getByRole('button', { name: '/home' }).click();
+    await frame.getByRole('option', { name: '/tmp' }).click();
+
+    const removeRootButton = frame
+      .getByRole('row')
+      .nth(1)
+      .getByRole('button')
+      .nth(4);
+
+    await expect(removeRootButton).toBeDisabled();
+
+    await frame
+      .getByRole('textbox', { name: 'mountpoint suffix' })
+      .fill('/usb');
+
+    await frame.getByPlaceholder('Define minimum size').nth(1).fill('10');
+    await frame.getByRole('button', { name: 'GiB' }).nth(1).click();
+    await frame.getByRole('option', { name: 'KiB' }).click();
+
+    await expect(removeRootButton).toBeDisabled();
+
+    await frame.getByRole('button', { name: 'Add LVM volume group' }).click();
+
+    await frame
+      .getByRole('textbox', { name: 'Volume group name input' })
+      .fill('vg-name');
+    await frame
+      .getByRole('textbox', { name: 'minimum partition size' })
+      .nth(1)
+      .fill('10');
+    await frame.getByRole('button', { name: 'GiB' }).nth(1).click();
+    await frame.getByRole('option', { name: 'KiB' }).click();
+
+    await frame
+      .getByRole('textbox', { name: 'Partition name input' })
+      .fill('lv1');
+    await frame.getByRole('button', { name: 'Add logical volume' }).click();
+    await frame.getByRole('button', { name: '/home' }).nth(1).click();
+    await frame.getByRole('option', { name: '/tmp' }).click();
+
+    await frame
+      .getByRole('row', {
+        name: 'Draggable row draggable button /tmp ext4 1 GiB',
+      })
+      .getByLabel('Partition name input')
+      .fill('lv2');
+    await frame
+      .getByRole('row', {
+        name: 'Draggable row draggable button lv2 /tmp ext4 1 GiB',
+      })
+      .getByLabel('mountpoint suffix')
+      .fill('/usb');
+    await frame
+      .getByRole('row', {
+        name: 'Draggable row draggable button lv2 /tmp /usb ext4 1 GiB',
+      })
+      .getByPlaceholder('Define minimum size')
+      .fill('10');
+    await frame.getByRole('button', { name: 'GiB' }).nth(2).click();
+    await frame.getByRole('option', { name: 'KiB' }).click();
+  });
+
+  await test.step('Fill the BP details', async () => {
+    await frame.getByRole('button', { name: 'Review and finish' }).click();
+    await fillInDetails(frame, blueprintName);
+  });
+
+  await test.step('Create BP', async () => {
+    await createBlueprint(frame, blueprintName);
+  });
+
+  await test.step('Edit BP', async () => {
+    await frame.getByRole('button', { name: 'Edit blueprint' }).click();
+    await frame.getByLabel('Revisit File system configuration step').click();
+
+    const removeRootButton = frame
+      .getByRole('row')
+      .nth(1)
+      .getByRole('button')
+      .nth(4);
+    await expect(removeRootButton).toBeDisabled();
+
+    const secondRow = frame.getByRole('row').nth(2);
+
+    const removeTmpButton = secondRow.getByRole('button').nth(4);
+    await expect(removeTmpButton).toBeEnabled();
+
+    await expect(
+      secondRow.getByRole('textbox', { name: 'mountpoint suffix' }),
+    ).toHaveValue('/usb');
+
+    await secondRow
+      .getByRole('gridcell', { name: '10', exact: true })
+      .getByPlaceholder('Define minimum size')
+      .click();
+    await secondRow
+      .getByRole('gridcell', { name: '10', exact: true })
+      .getByPlaceholder('Define minimum size')
+      .fill('5');
+
+    await secondRow.getByRole('button', { name: '/tmp' }).click();
+    await expect(
+      secondRow.getByRole('textbox', { name: 'mountpoint suffix' }),
+    ).toBeVisible();
+    await frame.getByRole('option', { name: '/usr' }).click();
+    await expect(
+      secondRow.getByRole('textbox', { name: 'mountpoint suffix' }),
+    ).toBeHidden();
+
+    await secondRow.getByRole('button', { name: '/usr' }).click();
+    await frame.getByRole('option', { name: '/srv' }).click();
+
+    await secondRow
+      .getByRole('textbox', { name: 'mountpoint suffix' })
+      .fill('/data');
+
+    await secondRow.getByRole('button', { name: 'KiB' }).click();
+    await frame.getByRole('option', { name: 'MiB' }).click();
+
+    await frame
+      .getByRole('textbox', { name: 'Volume group name input' })
+      .fill('vg-edited-name');
+    await frame
+      .getByRole('textbox', { name: 'Partition name input' })
+      .nth(1)
+      .fill('lv1-edited');
+
+    await frame.getByRole('button', { name: 'ext4' }).nth(1).click();
+    await frame.getByRole('option', { name: 'xfs' }).click();
+
+    await frame.getByRole('button', { name: 'Review and finish' }).click();
+    await frame
+      .getByRole('button', { name: 'Save changes to blueprint' })
+      .click();
+  });
+
+  let exportedBP = '';
+  await test.step('Export BP', async () => {
+    exportedBP = await exportBlueprint(page);
+    await cleanup.add(async () => {
+      await fsPromises.rm(path.dirname(exportedBP), { recursive: true });
+    });
+  });
+
+  // Temporarily commenting this out, needs to be addressed in a follow up
+  // await test.step('Review exported BP', async (step) => {
+  //   step.skip(
+  //     isHosted(),
+  //     'Only verify the contents of the exported blueprint in cockpit',
+  //   );
+  //   await verifyExportedBlueprint(exportedBP, exportedDiskBP(blueprintName));
+  // });
+
+  await test.step('Import BP', async (step) => {
+    step.skip(!isHosted(), 'Importing is not available in the plugin');
+    await importBlueprint(page, exportedBP);
+  });
+
+  await test.step('Review imported BP', async (step) => {
+    step.skip(!isHosted(), 'Importing is not available in the plugin');
+    await fillInImageOutputGuest(page);
+    await frame
+      .getByRole('button', { name: 'File system configuration' })
+      .click();
+
+    const removeRootButton = frame
+      .getByRole('row')
+      .nth(1)
+      .getByRole('button')
+      .nth(4);
+
+    await expect(removeRootButton).toBeDisabled();
+
+    const secondRow = frame.getByRole('row').nth(2);
+
+    const removeTmpButton = secondRow.getByRole('button').nth(4);
+    await expect(removeTmpButton).toBeEnabled();
+
+    const dataTextbox = secondRow.getByRole('textbox', {
+      name: 'mountpoint suffix',
+    });
+    await expect(dataTextbox).toHaveValue('/data');
+
+    const size = secondRow.getByPlaceholder('Define minimum size');
+    await expect(size).toHaveValue('5');
+
+    const typeButton = secondRow.getByRole('button', { name: 'xfs' });
+    await expect(typeButton).toBeVisible();
+
+    const unitButton = secondRow.getByRole('button', { name: 'MiB' });
+    await expect(unitButton).toBeVisible();
+
+    await page.getByRole('button', { name: 'Cancel' }).click();
+  });
+});

playwright/Customizations/Filesystem.spec.ts

@@ -66,7 +66,7 @@ test('Create a blueprint with Filesystem customization', async ({
     await newPageAutomatic.close();
 
     await frame
-      .getByRole('radio', { name: 'Manually configure partitions' })
+      .getByRole('radio', { name: 'Basic filesystem partitioning' })
       .click();
     const [newPageManual] = await Promise.all([
       page.context().waitForEvent('page'),
@@ -101,7 +101,7 @@ test('Create a blueprint with Filesystem customization', async ({
       .fill('/usb');
     await frame
       .getByRole('gridcell', { name: '1', exact: true })
-      .getByPlaceholder('File system')
+      .getByPlaceholder('Define minimum size')
       .fill('1000');
     await frame.getByRole('button', { name: 'GiB' }).nth(1).click();
     await frame.getByRole('option', { name: 'KiB' }).click();
@@ -152,11 +152,11 @@ test('Create a blueprint with Filesystem customization', async ({
 
     await frame
       .getByRole('gridcell', { name: '1000', exact: true })
-      .getByPlaceholder('File system')
+      .getByPlaceholder('Define minimum size')
       .click();
     await frame
       .getByRole('gridcell', { name: '1000', exact: true })
-      .getByPlaceholder('File system')
+      .getByPlaceholder('Define minimum size')
       .fill('1024');
 
     await frame.getByRole('button', { name: '/tmp' }).click();
@@ -237,7 +237,7 @@ test('Create a blueprint with Filesystem customization', async ({
 
     const size = frame
       .getByRole('gridcell', { name: '1', exact: true })
-      .getByPlaceholder('File system');
+      .getByPlaceholder('Define minimum size');
     await expect(size).toHaveValue('1');
 
     const unitButton = frame.getByRole('button', { name: 'GiB' }).nth(1);

playwright/fixtures/data/exportBlueprintContents.ts

@@ -1,3 +1,31 @@
+export const exportedDiskBP = (blueprintName: string): string => {
+  return `name = "${blueprintName}"
+
+[customizations]
+[[customizations.disk.partitions]]
+type = "plain"
+mountpoint = "/data"
+fs_type = "ext4"
+minsize = "50 GiB"
+
+[[customizations.disk.partitions]]
+type = "lvm"
+name = "mainvg"
+minsize = "20 GiB"
+
+[[customizations.disk.partitions.logical_volumes]]
+name = "rootlv"
+mountpoint = "/"
+fs_type = "ext4"
+minsize = "2 GiB"
+
+[customizations.timezone]
+timezone = "Etc/UTC"
+
+[customizations.locale]
+languages = [ "C.UTF-8" ]`;
+};
+
 export const exportedFilesystemBP = (blueprintName: string): string => {
   return `name = "${blueprintName}"