Skip to content

Conversation

@schutzbot
Copy link
Collaborator

Update api code generation

@schutzbot schutzbot requested a review from a team as a code owner November 15, 2025 05:19
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coderabbitai
Copy link

coderabbitai bot commented Nov 15, 2025

📝 Walkthrough

Walkthrough

The Distributions type declaration in the image builder API was expanded to include two additional distribution variants. Specifically, the type now recognizes 'rhel-9.9-nightly' and 'rhel-10.3-nightly' as valid distribution options. This change extends the supported distribution definitions without modifying any underlying logic or error-handling mechanisms.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a51f88b and 27ae2a4.

📒 Files selected for processing (1)
  • src/store/service/imageBuilderApi.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:centos-stream-9-aarch64
  • GitHub Check: rpm-build:fedora-41-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:centos-stream-10-aarch64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: testing-farm:fedora-41-x86_64:self
  • GitHub Check: testing-farm:fedora-42-x86_64:self
  • GitHub Check: testing-farm:centos-stream-10-x86_64:self
  • GitHub Check: testing-farm:fedora-43-x86_64:self
  • GitHub Check: rpm-build:centos-stream-9-aarch64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:fedora-41-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:centos-stream-10-aarch64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: Sourcery review
  • GitHub Check: playwright-tests
  • GitHub Check: Service Tests
🔇 Additional comments (1)
src/store/service/imageBuilderApi.ts (1)

413-413: LGTM! The new distribution values are correctly integrated.

The additions of "rhel-9.9-nightly" and "rhel-10.3-nightly" follow the existing naming pattern and are properly placed within the Distributions union type. The changes are purely additive and automatically supported across the codebase, including test fixtures and state management code in src/store/wizardSlice.ts.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.88%. Comparing base (a51f88b) to head (27ae2a4).

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3828   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files         218      218           
  Lines       25309    25309           
  Branches     2451     2451           
=======================================
  Hits        20219    20219           
  Misses       5061     5061           
  Partials       29       29           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51f88b...27ae2a4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regexowl
Copy link
Collaborator

Changes addressed in #3829

@regexowl regexowl closed this Nov 17, 2025
@regexowl regexowl deleted the update-apis branch November 17, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants