check-host-config: add RunOn filtering and re-enable modularity check#2213
Open
lzap wants to merge 6 commits intoosbuild:mainfrom
Open
check-host-config: add RunOn filtering and re-enable modularity check#2213lzap wants to merge 6 commits intoosbuild:mainfrom
lzap wants to merge 6 commits intoosbuild:mainfrom
Conversation
achilleas-k
previously approved these changes
Feb 18, 2026
Member
achilleas-k
left a comment
achilleas-k
left a comment
There was a problem hiding this comment.
Very nice. Thank you!
LGTM
bcl
reviewed
Feb 19, 2026
Contributor
Author
|
Need to repro locally not sure how tho: |
avitova
reviewed
Feb 23, 2026
Contributor
Author
|
Added a test, incorporated @avitova comment. Also, I have found out that CentOS 9 Stream has slightly different output of Finally, I consolidated the modularity test by using backtick strings instead of regular strings. This is in a separate commit. Bumped rngseed again to see tests passing hopefully now. |
Contributor
|
I am good here:) |
Add a RunOn field to the Metadata struct and use it to filter checks based on the OS ID and version. The RunOn field is a list of OS IDs to run the check on (prefix with `!` to exclude). The OS ID and version are extracted from the /etc/os-release file. Uses the functionality to only run modularity check on CentOS 9.
It looks like on some clouds (Azure), dnf can ask to import a key which can be forced using -y option.
CentOS 9 dnf module list output is different from RHEL 9, so we need to parse it differently. Instead of prefixed amount of headers, the check now detects table rows dynamically. Tests will be updated in a follow-up commit.
supakeen
force-pushed
the
host-checks-4
branch
from
ce8602c to
961a09e
Compare
supakeen
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a RunOn field to the Metadata struct and use it to filter checks
based on the OS ID and version. The RunOn field is a list of OS IDs to
run the check on (prefix with
!to exclude). The OS ID and version areextracted from the /etc/os-release file.
Uses the functionality to only run modularity check on CentOS 9.
Also enables the modularity test and use filter to run it only on CentOS 9.