Skip to content

Revert "Provide defaults for network_connectivity_network_cidr (#194)" #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "Provide defaults for network_connectivity_network_cidr (#194)" #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions roles/network_connectivity/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,13 @@
- "{{ network_connectivity_ping_count }}"
- "{{ item }}"
vars:
# provided defaults for `network_connectivity_network_cidr` are redundant to the role defaults and may be removed with the fix of
# https://github.com/ansible/ansible-lint/issues/4173
ip_version: >-
{{
'ipv4'
if network_connectivity_network_cidr | default('127.0.0.0/8') | ansible.utils.ipv4 | length > 0
if network_connectivity_network_cidr | ansible.utils.ipv4 | length > 0
else (
'ipv6'
if network_connectivity_network_cidr | default('::1/128') | ansible.utils.ipv6 | length > 0
if network_connectivity_network_cidr | ansible.utils.ipv6 | length > 0
else
None
)
Expand Down