Copy file stats to archive entry - #1086
Merged
Merged
Conversation
Add archive_entry_copy_stat() call to ensure file metadata (permissions, timestamps, ownership) is properly preserved when creating archive entries. This fixes incomplete file metadata in archives.
tigrim
reviewed
Jul 27, 2026
| stat(filename, &st); | ||
| entry = archive_entry_new(); | ||
| auto fileNameReplacedArray = fileName.replace(basePath + QStringLiteral("/"), QStringLiteral("")).toUtf8(); | ||
| archive_entry_copy_stat(entry, &st); |
Contributor
There was a problem hiding this comment.
If the goal of this PR is only to fix the file timestamp in the ZIP archive, it would be better to set it explicitly with archive_entry_set_mtime(entry, st.st_mtime, 0); rather than copying the entire stat structure.
Replace archive_entry_copy_stat() with archive_entry_set_mtime() to preserve only the modification time instead of copying all stat metadata. This ensures consistent behavior and avoids potential platform-specific stat field issues when writing archive entries.
tigrim
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add archive_entry_copy_stat() call to ensure file metadata (permissions, timestamps, ownership) is properly preserved when creating archive entries. This fixes incomplete file metadata in archives.