Skip to content

Import favorites into the opened folder - #26276

Open
vshcherb wants to merge 1 commit into
masterfrom
fix_fav_import_into_folder
Open

vshcherb wants to merge 1 commit into
masterfrom
fix_fav_import_into_folder

Conversation

@vshcherb

Copy link
Copy Markdown
Member

Fixes #25775.

Import from inside a favorites folder (empty-folder "Import" button) ignored that folder: points went to the category from the GPX <type> or to a folder named after the file. Now FavoriteFolderFragment passes its path to FavoritesImportTask, which puts the points under it and keeps the file's own groups as subfolders (with their appearance). The personal category (home/work/parking) is not moved. Import from the folder list works as before.

Checked: compiles (compileNightlyFreeLegacyFatDebugJavaWithJavac); not run on a device.

AI disclaimer

Produced with Claude Code (Opus 5.5).

Prompts used (summarised):

  1. What can we fix in Importing favorites goes to the wrong place. #25775, and is it worth fixing?
  2. Make a PR to master.

Decided by the agent, not requested explicitly: keep the imported file's groups as subfolders of the target folder instead of flattening them; points without a group go straight into the folder (not into a subfolder named after the file); leave the personal category (home/work/parking) at the root; only the folder screen passes a target, the folder list keeps the old behaviour.

Importing from a favorites folder ignored the folder: points went to the
category from the file (or the file name). Now they go under the opened
folder, keeping the file's own groups as subfolders; the personal
category (home/work/parking) stays in place.

Fixes #25775

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing favorites goes to the wrong place.

1 participant