Correct GeoJSON ring orientation#2977
Merged
Merged
Conversation
Contributor
Author
|
Tests are failing but I would rather keep this scoped to GeoJSON rather than adding |
Collaborator
|
Beautiful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct all remaining source geometries whose ring orientation does not match GeoJSON RFC7946.
This applies the same orientation convention enforced by
scripts/strict_check.py: exterior rings counterclockwise and interior rings clockwise.Why this is needed:
.github/workflows/pull_request.ymlrunsscripts/strict_check.pyonly on changed files while.github/workflows/push.ymlruns the basic check only.This PR is geometry-only: properties, URLs, attribution, dates, and other source metadata are unchanged.
This is blocking follow-up maintenance PRs #2974 and #2975: those PRs touch existing source files, which causes
strict_check.pyto run on them and surface latent RFC7946 ring-orientation failures unrelated to the intended metadata/URL changes.Validation performed:
sources/**/*.geojsonpolygons and multipolygons using Shapelyorient(..., sign=1.0), matching the helper used bystrict_check.py.git diff --check.Disclosure: Generated by GPT 5.5 with human oversight