Support for unlimited (-1) value in ulimit extension#352
Merged
Conversation
tfoote
approved these changes
Feb 20, 2026
Collaborator
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
Reviewing thisI was considering more generic matches, but since -1 is a special value this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of improving determinism of control applications inside containers, the
ros2_controldocumentation suggests using unlimited-1value for thememlocklimit. However, the validation regular expression used here does not allow for the minus symbol in-1.Also tried with
unlimitedwhich is equivalent when defining limits inlimits.confbut, while it gets correctly validated by the extension here, it is not accepted as an argument bydocker run.I propose a change to the validation regular expression used, which should accept the special
-1value.