build(plugins): Only compile against a plugin API#12116
Draft
sschuberth wants to merge 1 commit into
Draft
Conversation
A plugin should only compile against the API for its plugin type to avoid the plugin API itself being a dependency of the plugin, which would cause problems when bundling the dependencies of plugins and using multiple plugins, as the plugin API would duplicate then. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12116 +/- ##
=========================================
Coverage 58.60% 58.60%
Complexity 1827 1827
=========================================
Files 361 361
Lines 13578 13578
Branches 1404 1404
=========================================
Hits 7958 7958
Misses 5114 5114
Partials 506 506
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plugin should only compile against the API for its plugin type to avoid the plugin API itself being a dependency of the plugin, which would cause problems when bundling the dependencies of plugins and using multiple plugins, as the plugin API would duplicate then.