Conversation
bhumulanandinireddy
left a comment
bhumulanandinireddy
left a comment
There was a problem hiding this comment.
@suprajamannava17 code logic looks good to me but, there are some changes according to the alignment ( it should be looking same like it was in the current preview panel) some space between the search terms the below image is the main branch's alinement for it.
And the other one is for the file heading and the search term should be in the middle of the page instead of beginning from the front.
|
@suprajamannava17 any update on the changes |
|
@suprajamannava17 I noticed if I closed the preview panel, I could not get it to reopen without deleting my search and starting over. It would be good if it could be easily re-opoened if accidentally closed. Also, one thing @bhumulanandinireddy and I talked about was having the preview panel slide in on an animation. maybe that's a separate issue, but the more I think about it the more I (irrationally) want to see it implemented 😄 |
Even if the preview is accidentally closed, you can click on "Preview" again to view the results for the current search. If you need to make any modifications, you can update the inputs and click "Preview" to see the latest results. However, I just realized there's an issue with the file changes — if the old files are deleted and new ones are added, the results still show data for all the previous files. I’ll work on fixing this and also add the animations. Thanks for pointing out the issue — I didn’t notice it until now. |
|
@suprajamannava17 can you raise a PR with the updated code ? we need to work on it asap and make our product ready by 30th April for the presentations |
|
@suprajamannava17
|
|
|
|
@suprajamannava17 If you can resolve the conflicts on this, I'll give it a review. I think you were onto something good with this update, and I'd like to see your hard work pay off. |
3 participants
Fixes #165
What was changed?
The OrcaDashboardComponent was modified to conditionally display the preview section alongside the form. The preview content now appears on the right only after clicking the Preview button, and can be closed using a close button to re-center the form.
Why was it changed?
Previously, clicking the Preview button would open the preview content in a new window, which was not an ideal user experience. To provide a more seamless and integrated view, the preview section was modified to appear on the right side of the same page, while the ORCA Log Extraction form shifts to the left. This change enhances usability by keeping everything within a single view and avoiding context switching for the user.
How was it changed?
Changes were made in OrcaDashboardComponent.js. A new state variable showPreview was added to control the visibility of the preview section. The layout was updated using conditional rendering and Bootstrap grid classes to dynamically adjust column widths based on showPreview. The setShowPreview(true) was added when fetching the preview, and a close button was introduced to set showPreview(false) to hide the preview and re-center the form.
Screenshots that show the changes (if applicable):
