Skip to content

refactor: modify css classes#182

Open
MikeManzi wants to merge 2 commits intooss-slu:mainfrom
MikeManzi:main
Open

refactor: modify css classes#182
MikeManzi wants to merge 2 commits intooss-slu:mainfrom
MikeManzi:main

Conversation

@MikeManzi
Copy link

Fixes #174

What was changed?

  • AboutComponent.js
  • GaussianDashboardComponent.js
  • OrcaDashboardComponent.js
  • OrcaDashboardComponentLegacy.js
  • AboutComponent.css
  • OrcaDashboardComponent.css
  • OrcaDashboardComponentLegacy.css

Why was it changed?

  • Repeated occurrences of inline CSS were moved to corresponding stylesheets

border-bottom: 1px solid #fff;
}

.form-group {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal looks good on the separation into the CSS files, possibly we could combine/rename OrcaDashboardComponent.css and OrcaDashboardComponentLegacy.css, but that can be done in a different PR. Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize and Simplify Styling

5 participants