Conversation
|
Hi @dhyana6466 , would you be able to include a screenshot of the working output? |
The Top Contributors and Top Repositories section is rendering under Organization Overview. The “Loading Chart Data…” text is coming from an existing chart component and not from the Top Contributors/Repos component itself. |
ggondela1419
left a comment
There was a problem hiding this comment.
Overall, this looks pretty solid and the ranking logic is clear and straightforward. I added a few comments about performance, structure, data handling, and testing that should help as the project grows and moves toward backend integration. Once those are taken care of, this should be in great shape.
|
hi @dhyana6466 great work so far!! Grace also added some great comments that I think would be good to implement through your code. If you can let me know/resolve the comments as you change the relevant code I can go ahead and finish this pull request :) |
Hi @hcaballero2, thanks so much! I’ve gone through and addressed all of Grace’s comments, pushed the changes, and resolved the relevant threads as I made updates. I also verified everything locally and all tests are passing now. Please let me know if there’s anything else you’d like me to tweak — happy to take a look! |
|
Waiting for further commenting in line with CodingConventions document as discussed in class :), I think the comments you have so far are really great and give some good clarification, I just <3 parameter specific comments. |
Thanks! I’ve added parameter-specific comments and aligned the updates with the CodingConventions document we discussed in class. Let me know if there’s anything else you’d like me to adjust |
|
Beautiful work @dhyana6466 !! Nothing else is needed from your end I am just working on getting the merging error resolved |
Description
This PR adds a reusable Home page component that displays the top contributors and top repositories in the organization based on volume statistics. The component ranks contributors and repositories by overall activity and is intended to provide visibility and encourage healthy competition across teams.
The component currently uses
test_data.jsonas a temporary data source and is structured to be easily updated once backend integration is completed.Fixes #106
Type of change
How Has This Been Tested?
The feature was tested locally by running the application and verifying that the Top Contributors and Top Repositories sections render correctly on the Home page using the provided test data.
Test Configuration:
Checklist:
Screenshot Ouput