Skip to content

Code refactoring for auth/index.js#54

Open
Mehulantony wants to merge 14 commits intomainfrom
code-refactor
Open

Code refactoring for auth/index.js#54
Mehulantony wants to merge 14 commits intomainfrom
code-refactor

Conversation

@Mehulantony
Copy link
Copy Markdown
Collaborator

@Mehulantony Mehulantony commented Mar 9, 2026

Performed code refactoring for the auth/index.js file and introduced the following changes for cleanup and maintainability:

  1. Extracted JWT payload parsing into one helper function parseAuthHeaderPayload(req)
  2. Fixed typo issues in _extractUser
  3. Used consistent quote style and spacing
  4. Extracted repeated Auth0 fetch logic into one helper function requestTokenFromAuth0

@Mehulantony Mehulantony requested a review from allenbakki March 9, 2026 20:32
allenbakki
allenbakki reviewed Mar 28, 2026
View reviewed changes
Comment thread auth/index.js
Comment thread auth/index.js
Comment thread auth/index.js
Comment thread auth/index.js
Comment thread auth/index.js
Comment thread auth/index.js Outdated
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 25, 2026
View reviewed changes
Comment thread routes/_gog_fragments_from_manuscript.js Fixed
Comment thread routes/_gog_glosses_from_manuscript.js Fixed
Comment thread routes/bulkCreate.js Fixed
Comment thread routes/bulkUpdate.js Fixed
Comment thread routes/client.js Fixed
Comment thread routes/patchUnset.js Fixed
Comment thread routes/patchUpdate.js Fixed
Comment thread routes/patchUpdate.js Fixed
Comment thread routes/putUpdate.js Fixed
Comment thread routes/release.js Fixed
Mehulantony and others added 2 commits April 24, 2026 21:14
@Mehulantony @github-advanced-security
Potential fix for pull request finding 'CodeQL / Missing rate limiting'
4306c29 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Mehulantony
fix failing tests
22f2e19
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 25, 2026
View reviewed changes
Comment thread routes/patchUnset.js Fixed
Mehulantony and others added 8 commits April 24, 2026 21:32
@Mehulantony @github-advanced-security
Potential fix for pull request finding 'CodeQL / Missing rate limiting'
9e4caf8 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Mehulantony @github-advanced-security
Potential fix for pull request finding 'CodeQL / Missing rate limiting'
a8351cc 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Mehulantony @github-advanced-security
Potential fix for pull request finding 'CodeQL / Missing rate limiting'
98b6869 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Mehulantony
removed cookie parser
6bb73ea
@Mehulantony
Add express-rate-limit dependency
fe1970f
@Mehulantony
Merge branch 'main' of https://github.com/oss-slu/rerum_server_nodejs …
71fb63a 
…into code-refactor
@Mehulantony @allenbakki
Update auth/index.js
b2266a1 
Co-authored-by: Reshma Dudekula <96569997+allenbakki@users.noreply.github.com>
@Mehulantony
Merge branch 'main' into code-refactor
15c68a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allenbakki allenbakki allenbakki left review comments

@thehabes thehabes Awaiting requested review from thehabes thehabes is a code owner

@cubap cubap Awaiting requested review from cubap cubap is a code owner

+1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Mehulantony Mehulantony

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mehulantony @github-advanced-security @allenbakki