Refactored controller errors#76
Open
joeljoby02 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Looks good to me. The validation check for an empty JSON object is clear and prevents accidental broad queries, which is important. Also, pulling the error creation into a separate function is a solid approach. It keeps things cleaner and makes the error handling logic easier to maintain and reuse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Standardize Controller Error Creation based on issue #70
createError(status, message, details)helper in utils.jsObject.assign()error construction withcreateError()in controller filescrud,delete,release,overwrite, andsearch