Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSCAL validation action #199

Merged
merged 6 commits into from
Feb 21, 2025
Merged

OSCAL validation action #199

merged 6 commits into from
Feb 21, 2025

Conversation

puerco
Copy link
Member

@puerco puerco commented Feb 21, 2025

This PR adds a github action to verify the OSCAL output of the baseline compiler whenever a PR is opened.

This PR introduces a new file but requires #194 to run, here is an example run:
https://github.com/puerco/security-baseline/actions/runs/13448472115/job/37578580471

Signed-off-by: Adolfo García Veytia (Puerco) [email protected]

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Copy link
Contributor

@xee5ch xee5ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be labor an obvious point, but oscal-club (actually yours truly as fun else contributed) has a packaged action that wraps the oscal-cli tooling, be it the classic NIST version and an updated fork from former NIST staff in the metaschema-framework community-fork that does some more bells and whistles than just JSON Schema validation, including SARIF output so you can overly the results on the files themselves in GitHub user interface.

I just thought I would put that out there if you want to consider it. If not, I completely understand, but it might help test multiple toolchains for conformance.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco
Copy link
Member Author

puerco commented Feb 21, 2025

Ah nice, I added it to also verify with it (see this workflow run here) and it actually caught more details.

It is not failing the workflow when validation fails but apparently, this is on purpose. I will leave it like non-failing like this while I fix the output to also validate with the oscal cli. Thanks for the suggestion.

Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkout action doesn't drop credentials by default, which can result in a leak.

Otherwise, this looks good to me and to zizmor.

SecurityCRob and others added 2 commits February 21, 2025 15:56
Co-authored-by: Ben Cotton <[email protected]>
Signed-off-by: CRob <[email protected]>
Co-authored-by: Ben Cotton <[email protected]>
Signed-off-by: CRob <[email protected]>
Signed-off-by: Ben Cotton <[email protected]>
@funnelfiasco funnelfiasco merged commit 79a1714 into ossf:main Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants